Oracle vote extensions #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mintthemoon
approved these changes
Jan 11, 2024
…fault and vote extension functionalities
codehans
reviewed
Jan 24, 2024
| @@ -10,12 +10,9 @@ option go_package = "github.com/Team-Kujira/core/x/oracle/types"; | |||
| // GenesisState defines the oracle module's genesis state. | |||
| message GenesisState { | |||
| Params params = 1 [(gogoproto.nullable) = false]; | |||
| repeated FeederDelegation feeder_delegations = 2 [(gogoproto.nullable) = false]; | |||
| repeated ExchangeRateTuple exchange_rates = 3 | |||
| repeated ExchangeRateTuple exchange_rates = 2 | |||
There was a problem hiding this comment.
Maybe we should retain the same indexes for the same properties? Make an old genesis export compatible with the new module
There was a problem hiding this comment.
Genesis encoding/decoding's done in JSON and proto index won't be affected I believe.
antstalepresh
force-pushed
the
oracle-vote-extensions
branch
from
a8d994a to
718bc47
Compare
…into oracle-vote-extensions
codehans
force-pushed
the
oracle-vote-extensions
branch
from
bccf555 to
e4dbc99
Compare
antstalepresh
force-pushed
the
oracle-vote-extensions
branch
from
e4dbc99 to
b5777ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.